CLEANUP: FIXME comments

This commit is contained in:
Jeremy Wall 2018-05-27 14:55:21 -05:00
parent cefb307783
commit bfdf5da834
4 changed files with 2 additions and 5 deletions

View File

@ -1057,7 +1057,6 @@ impl Builder {
} }
} }
// FIXME(jwall): We still need to write unit tests for these.
fn eval_list_op(&self, def: &ListOpDef) -> Result<Rc<Val>, Box<Error>> { fn eval_list_op(&self, def: &ListOpDef) -> Result<Rc<Val>, Box<Error>> {
let l = &def.target.elems; let l = &def.target.elems;
let mac = &def.mac; let mac = &def.mac;

View File

@ -17,7 +17,7 @@ use std::io::Result;
use std::io::Write; use std::io::Write;
use std::rc::Rc; use std::rc::Rc;
use ast::*; use ast::Positioned;
use build::Val; use build::Val;
use convert::traits::Converter; use convert::traits::Converter;
@ -51,7 +51,6 @@ impl EnvConverter {
} }
fn convert_list(&self, _items: &Vec<Rc<Val>>, _w: &mut Write) -> Result<()> { fn convert_list(&self, _items: &Vec<Rc<Val>>, _w: &mut Write) -> Result<()> {
// FIXME(jwall): Fill this in?
// TODO(jwall) // TODO(jwall)
eprintln!("Skipping List..."); eprintln!("Skipping List...");
Ok(()) Ok(())

View File

@ -79,7 +79,6 @@ impl FlagConverter {
try!(write!(w, "'{}' ", s)); try!(write!(w, "'{}' ", s));
} }
&Val::List(ref _def) => { &Val::List(ref _def) => {
// FIXME(jwall): Fill this in?
eprintln!("Skipping List..."); eprintln!("Skipping List...");
} }
&Val::Tuple(ref flds) => for &(ref name, ref val) in flds.iter() { &Val::Tuple(ref flds) => for &(ref name, ref val) in flds.iter() {

View File

@ -597,7 +597,7 @@ fn test_expression_parse() {
kind: BinaryExprType::Add, kind: BinaryExprType::Add,
left: Box::new(Expression::Simple(Value::Int(value_node!(1, 1, 2)))), left: Box::new(Expression::Simple(Value::Int(value_node!(1, 1, 2)))),
right: Box::new(Expression::Simple(Value::Int(value_node!(1, 1, 6)))), right: Box::new(Expression::Simple(Value::Int(value_node!(1, 1, 6)))),
pos: Position::new(1, 2), // FIXME(jwall): grouped expressions appear to be getting positioned wrong pos: Position::new(1, 2),
}))) })))
); );
assert_parse!( assert_parse!(