diff --git a/src/build/mod.rs b/src/build/mod.rs index e93aa18..7eb49fb 100644 --- a/src/build/mod.rs +++ b/src/build/mod.rs @@ -1057,7 +1057,6 @@ impl Builder { } } - // FIXME(jwall): We still need to write unit tests for these. fn eval_list_op(&self, def: &ListOpDef) -> Result, Box> { let l = &def.target.elems; let mac = &def.mac; diff --git a/src/convert/env.rs b/src/convert/env.rs index 3fc36b0..fe1fd09 100644 --- a/src/convert/env.rs +++ b/src/convert/env.rs @@ -17,7 +17,7 @@ use std::io::Result; use std::io::Write; use std::rc::Rc; -use ast::*; +use ast::Positioned; use build::Val; use convert::traits::Converter; @@ -51,7 +51,6 @@ impl EnvConverter { } fn convert_list(&self, _items: &Vec>, _w: &mut Write) -> Result<()> { - // FIXME(jwall): Fill this in? // TODO(jwall) eprintln!("Skipping List..."); Ok(()) diff --git a/src/convert/flags.rs b/src/convert/flags.rs index 697c944..4ebf500 100644 --- a/src/convert/flags.rs +++ b/src/convert/flags.rs @@ -79,7 +79,6 @@ impl FlagConverter { try!(write!(w, "'{}' ", s)); } &Val::List(ref _def) => { - // FIXME(jwall): Fill this in? eprintln!("Skipping List..."); } &Val::Tuple(ref flds) => for &(ref name, ref val) in flds.iter() { diff --git a/src/parse/test.rs b/src/parse/test.rs index b5be55c..b7235a4 100644 --- a/src/parse/test.rs +++ b/src/parse/test.rs @@ -597,7 +597,7 @@ fn test_expression_parse() { kind: BinaryExprType::Add, left: Box::new(Expression::Simple(Value::Int(value_node!(1, 1, 2)))), right: Box::new(Expression::Simple(Value::Int(value_node!(1, 1, 6)))), - pos: Position::new(1, 2), // FIXME(jwall): grouped expressions appear to be getting positioned wrong + pos: Position::new(1, 2), }))) ); assert_parse!(