mirror of
https://github.com/zaphar/ucg.git
synced 2025-07-22 18:19:54 -04:00
CLEANUP: FIXME comments
This commit is contained in:
parent
cefb307783
commit
bfdf5da834
@ -1057,7 +1057,6 @@ impl Builder {
|
||||
}
|
||||
}
|
||||
|
||||
// FIXME(jwall): We still need to write unit tests for these.
|
||||
fn eval_list_op(&self, def: &ListOpDef) -> Result<Rc<Val>, Box<Error>> {
|
||||
let l = &def.target.elems;
|
||||
let mac = &def.mac;
|
||||
|
@ -17,7 +17,7 @@ use std::io::Result;
|
||||
use std::io::Write;
|
||||
use std::rc::Rc;
|
||||
|
||||
use ast::*;
|
||||
use ast::Positioned;
|
||||
use build::Val;
|
||||
use convert::traits::Converter;
|
||||
|
||||
@ -51,7 +51,6 @@ impl EnvConverter {
|
||||
}
|
||||
|
||||
fn convert_list(&self, _items: &Vec<Rc<Val>>, _w: &mut Write) -> Result<()> {
|
||||
// FIXME(jwall): Fill this in?
|
||||
// TODO(jwall)
|
||||
eprintln!("Skipping List...");
|
||||
Ok(())
|
||||
|
@ -79,7 +79,6 @@ impl FlagConverter {
|
||||
try!(write!(w, "'{}' ", s));
|
||||
}
|
||||
&Val::List(ref _def) => {
|
||||
// FIXME(jwall): Fill this in?
|
||||
eprintln!("Skipping List...");
|
||||
}
|
||||
&Val::Tuple(ref flds) => for &(ref name, ref val) in flds.iter() {
|
||||
|
@ -597,7 +597,7 @@ fn test_expression_parse() {
|
||||
kind: BinaryExprType::Add,
|
||||
left: Box::new(Expression::Simple(Value::Int(value_node!(1, 1, 2)))),
|
||||
right: Box::new(Expression::Simple(Value::Int(value_node!(1, 1, 6)))),
|
||||
pos: Position::new(1, 2), // FIXME(jwall): grouped expressions appear to be getting positioned wrong
|
||||
pos: Position::new(1, 2),
|
||||
})))
|
||||
);
|
||||
assert_parse!(
|
||||
|
Loading…
x
Reference in New Issue
Block a user