zaphar/ucg
1
0
Fork 0
mirror of https://github.com/zaphar/ucg.git synced 2025-07-22 18:19:54 -04:00
Code Issues Packages Projects Releases Wiki Activity

MAINT: Cleanup todos and unnecessary code.

Browse Source
This commit is contained in:
Jeremy Wall 2019-04-08 21:39:50 -05:00
parent 9990c14692
commit 1f7d405a3b
1 changed files with 0 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/build/mod.rs
View File

@ -141,7 +141,6 @@ macro_rules! eval_binary_expr {
}; };
} }
// TODO(jwall): Use the builder pattern here. Just like AstWalker.
impl<'a> FileBuilder<'a> { impl<'a> FileBuilder<'a> {
/// Constructs a new Builder. /// Constructs a new Builder.
pub fn new<P: Into<PathBuf>>( pub fn new<P: Into<PathBuf>>(
@ -151,16 +150,6 @@ impl<'a> FileBuilder<'a> {
) -> Self { ) -> Self {
let env_vars: Vec<(String, String)> = env::vars().collect(); let env_vars: Vec<(String, String)> = env::vars().collect();
let scope = scope::Scope::new(Rc::new(Val::Env(env_vars))); let scope = scope::Scope::new(Rc::new(Val::Env(env_vars)));
Self::new_with_scope(working_dir, import_paths, cache, scope)
}
/// Constructs a new Builder with a provided scope.
pub fn new_with_scope<P: Into<PathBuf>>(
working_dir: P,
import_paths: &'a Vec<PathBuf>,
cache: Rc<RefCell<assets::Cache>>,
scope: Scope,
) -> Self {
FileBuilder { FileBuilder {
// Our import stack is initialized with ourself. // Our import stack is initialized with ourself.
working_dir: working_dir.into(), working_dir: working_dir.into(),
@ -204,11 +193,6 @@ impl<'a> FileBuilder<'a> {
} }
} }
// TODO(jwall): With builder pattern
pub fn set_build_output(&mut self, scope: ValueMap) {
self.scope.build_output = scope;
}
/// Builds a ucg file at the named path. /// Builds a ucg file at the named path.
pub fn build<P: Into<PathBuf>>(&mut self, file: P) -> BuildResult { pub fn build<P: Into<PathBuf>>(&mut self, file: P) -> BuildResult {
let file = file.into(); let file = file.into();