From 1f7d405a3b79a4a89fdd4114b218d53fcb7cbad4 Mon Sep 17 00:00:00 2001 From: Jeremy Wall Date: Mon, 8 Apr 2019 21:39:50 -0500 Subject: [PATCH] MAINT: Cleanup todos and unnecessary code. --- src/build/mod.rs | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/src/build/mod.rs b/src/build/mod.rs index 57f2ce9..d941635 100644 --- a/src/build/mod.rs +++ b/src/build/mod.rs @@ -141,7 +141,6 @@ macro_rules! eval_binary_expr { }; } -// TODO(jwall): Use the builder pattern here. Just like AstWalker. impl<'a> FileBuilder<'a> { /// Constructs a new Builder. pub fn new>( @@ -151,16 +150,6 @@ impl<'a> FileBuilder<'a> { ) -> Self { let env_vars: Vec<(String, String)> = env::vars().collect(); let scope = scope::Scope::new(Rc::new(Val::Env(env_vars))); - Self::new_with_scope(working_dir, import_paths, cache, scope) - } - - /// Constructs a new Builder with a provided scope. - pub fn new_with_scope>( - working_dir: P, - import_paths: &'a Vec, - cache: Rc>, - scope: Scope, - ) -> Self { FileBuilder { // Our import stack is initialized with ourself. working_dir: working_dir.into(), @@ -204,11 +193,6 @@ impl<'a> FileBuilder<'a> { } } - // TODO(jwall): With builder pattern - pub fn set_build_output(&mut self, scope: ValueMap) { - self.scope.build_output = scope; - } - /// Builds a ucg file at the named path. pub fn build>(&mut self, file: P) -> BuildResult { let file = file.into();