mirror of
https://github.com/zaphar/ucg.git
synced 2025-07-26 19:00:28 -04:00
MAINT: Cleanup some todos and wording.
This commit is contained in:
parent
708f23c674
commit
263e91c9f9
@ -141,7 +141,7 @@ macro_rules! eval_binary_expr {
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
// TODO(jwall): Use the builder patter here. Just like AstWalker.
|
// TODO(jwall): Use the builder pattern here. Just like AstWalker.
|
||||||
impl<'a> FileBuilder<'a> {
|
impl<'a> FileBuilder<'a> {
|
||||||
/// Constructs a new Builder.
|
/// Constructs a new Builder.
|
||||||
pub fn new<P: Into<PathBuf>>(
|
pub fn new<P: Into<PathBuf>>(
|
||||||
@ -1019,7 +1019,6 @@ impl<'a> FileBuilder<'a> {
|
|||||||
fn eval_binary(&self, def: &BinaryOpDef, scope: &Scope) -> Result<Rc<Val>, Box<dyn Error>> {
|
fn eval_binary(&self, def: &BinaryOpDef, scope: &Scope) -> Result<Rc<Val>, Box<dyn Error>> {
|
||||||
let kind = &def.kind;
|
let kind = &def.kind;
|
||||||
if let &BinaryExprType::IN = kind {
|
if let &BinaryExprType::IN = kind {
|
||||||
// TODO Should we support this operation on strings too?
|
|
||||||
return self.do_element_check(&def.left, &def.right, scope);
|
return self.do_element_check(&def.left, &def.right, scope);
|
||||||
}
|
}
|
||||||
if let &BinaryExprType::IS = kind {
|
if let &BinaryExprType::IS = kind {
|
||||||
|
Loading…
x
Reference in New Issue
Block a user