zaphar/ucg
1
0
Fork 0
mirror of https://github.com/zaphar/ucg.git synced 2025-07-22 18:19:54 -04:00
Code Issues Packages Projects Releases Wiki Activity

MAINT: Cleanup some todos and wording.

Browse Source
This commit is contained in:
Jeremy Wall 2019-03-23 21:16:30 -05:00
parent 708f23c674
commit 263e91c9f9
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/build/mod.rs
View File

@ -141,7 +141,7 @@ macro_rules! eval_binary_expr {
};
}
// TODO(jwall): Use the builder patter here. Just like AstWalker.
// TODO(jwall): Use the builder pattern here. Just like AstWalker.
impl<'a> FileBuilder<'a> {
/// Constructs a new Builder.
pub fn new<P: Into<PathBuf>>(
@ -1019,7 +1019,6 @@ impl<'a> FileBuilder<'a> {
fn eval_binary(&self, def: &BinaryOpDef, scope: &Scope) -> Result<Rc<Val>, Box<dyn Error>> {
let kind = &def.kind;
if let &BinaryExprType::IN = kind {
// TODO Should we support this operation on strings too?
return self.do_element_check(&def.left, &def.right, scope);
}
if let &BinaryExprType::IS = kind {